Add processing activity exports #621
Merged
+4,021
−226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
6 issues found across 21 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="pkg/probo/data_protection_impact_assessment_service.go">
<violation number="1" location="pkg/probo/data_protection_impact_assessment_service.go:383">
P1: PDF generation should happen outside the database transaction to keep it short-lived. Fetch data within the transaction, then perform HTML rendering and PDF generation afterward.
(Based on your team's feedback about splitting data fetching and PDF generation.) [FEEDBACK_USED]</violation>
</file>
<file name="pkg/probo/processing_activity_service.go">
<violation number="1" location="pkg/probo/processing_activity_service.go:459">
P1: PDF generation is performed inside the database transaction, which can hold connections open for extended periods. Move `RenderProcessingActivitiesTableHTML`, `GeneratePDF`, and `io.ReadAll` outside the transaction - fetch data within the transaction, then generate the PDF afterward.
(Based on your team's feedback about splitting data fetching and PDF generation.) [FEEDBACK_USED]</violation>
</file>
<file name="pkg/probo/transfer_impact_assessment_service.go">
<violation number="1" location="pkg/probo/transfer_impact_assessment_service.go:383">
P1: PDF generation should happen outside the database transaction. Fetch all required data within the transaction, then perform HTML rendering and PDF generation afterward. This keeps the transaction short-lived and prevents holding database connections during potentially slow PDF operations.
(Based on your team's feedback about splitting data fetching and PDF generation.) [FEEDBACK_USED]</violation>
</file>
<file name="e2e/console/processing_activity_test.go">
<violation number="1" location="e2e/console/processing_activity_test.go:2710">
P2: Test uses wrong client: `owner.Do()` should be `newOwner.Do()`. The test creates `newOwner` to get a fresh organization with no TIAs, but executes the query using `owner` from the outer scope.</violation>
<violation number="2" location="e2e/console/processing_activity_test.go:2710">
P2: Test uses wrong client: `owner.Do()` should be `newOwner.Do()`. The test creates `newOwner` to get a fresh organization with no DPIAs, but executes the query using `owner` from the outer scope.</violation>
<violation number="3" location="e2e/console/processing_activity_test.go:2710">
P2: Test uses wrong client: `owner.Do()` should be `newOwner.Do()`. The test creates `newOwner` to get a fresh organization with no processing activities, but executes the query using `owner` from the outer scope. This could cause the test to pass for wrong reasons or fail with authorization errors instead of the expected "no processing activities found" error.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
SachaProbo
force-pushed
the
add-processing-activity-exports
branch
6 times, most recently
from
65c5295 to
8f279f0
Compare
SachaProbo
force-pushed
the
add-processing-activity-exports
branch
from
8f279f0 to
9e4a316
Compare
SachaProbo
force-pushed
the
add-processing-activity-exports
branch
3 times, most recently
from
e1e738c to
c9843af
Compare
SachaProbo
force-pushed
the
add-processing-activity-exports
branch
8 times, most recently
from
a0145ec to
c9f5ba3
Compare
SachaProbo
force-pushed
the
add-processing-activity-exports
branch
from
c9f5ba3 to
ba95c98
Compare
Signed-off-by: Sacha Al Himdani <[email protected]>
SachaProbo
force-pushed
the
add-processing-activity-exports
branch
from
ba95c98 to
c76764b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processing-activities-2026-01-12-4.pdf
data-protection-impact-assessments-2026-01-12.pdf
transfer-impact-assessments-2026-01-12.pdf
Summary by cubic
Add PDF export for processing activities, DPIAs, and TIAs. Includes console UI, GraphQL mutations, server-side HTML-to-PDF generation, and permissions.
Written for commit c76764b. Summary will update on new commits.